Changes in behaviour in 18.4 vs 18.3: left key to exit, workspaces

Help
1

Hello,

I’ve recently updated: this behaviour is a little annoying. I can reproduce running atuin search -i directly, I can reproduce in full mode (rather than compact) and I’ve confirmed it doesn’t occur on 18.3. Is there some way to disable this change?

On both versions, the down key on the last line exits the search. I’m ok with that.

(Edit: the right key exits, too — I’d like to stop this.)

Thanks,
David

2

Aha, I found it! Right Arrow to modify selected command by bboynton97 · Pull Request #2453 · atuinsh/atuin · GitHub only talks about the right key in the metadata, though, so until I noticed that one exiting, I was unable to identify the change from the changelog.

I’ve also noticed that the workspace filter is no longer automatically activated, in git repositories. It had worked when I had filter_mode = "global" but now requires filter_mode = "workspace". That seems like a bugfix, but it means the documentation of the workspaces option is now misleading.

3

Yes: the workspace filter is an (undocumented) behaviour change. I think this is a bug in feat(client): add filter mode enablement and ordering configuration by pamburus · Pull Request #2430 · atuinsh/atuin · GitHub where the settings.workspaces is no longer checked in determining the filter mode.

I think the behaviour change is probably correct, though, and this ought to be clarified in the documentation?

4

Actually, from my perspective, this was unintentional. I did not mean to break backward compatibility.
I can fix it, but I am now worried about how this might affect new users. It is probably not a big deal for them because they likely use the new option instead of “workspaces”.
@ellie, what do you think?

5

I’d say just change the documentation, so that the workspaces option no longer claims to override whatever choice is made for the filter mode.

6

I think we should fix it so that workspaces = true still works as it did! Thanks for looking into this

7

Ok, I created pull request #2565.
However, there is one place I am not sure about.
Please take a look.

8

What about reverting left key/right key changes — do I have to wait for the (incoming) changes to allow custom keymap functionality in the TUI?

In any case: thanks for the quick responses! Glad I joined the forum. I noticed on signup that there are still template placeholders in the privacy policy and terms of conditions — I presume these should have been filled automatically?