Enable inline_height and compact ui by default

ellie · July 10, 2024, 11:29am

I’m looking to change some defaults - specifically, change Atuin to no longer take the full screen, and to use a slightly different UI style

Details here:

github.com/atuinsh/atuin

chore: enable inline height and compact by default

atuinsh:main ← atuinsh:ellie/inline-height-default

opened 11:20AM - 10 Jul 24 UTC

ellie

+2 -2

I've been running Atuin this way for a really long time, and have heard from qui…te a few users now that they weren't a fan of Atuin using the whole screen. **If you like this, please react with 👍** **If you don't, please react with 👎** This is how it looks: ![inline-height](https://github.com/atuinsh/atuin/assets/53315310/d5508cfe-b5c8-46e2-bbe5-7d5630cf47f1) However I have also learned that you only hear from people who _don't_ like the way things currently are, right up until you change them - and then hear from everyone that was happy and quiet. I'll try and circulate this PR as much as I can. It's the same as adding ``` style = "compact" inline_height = 40 ``` to the config file. If this change is merged, it will change how Atuin looks for people who don't have anything set in their config. If they don't like it, they can restore how things were with ``` style = "auto" inline_height = 0 ``` We could change the default config file so this only happens for new users, but I'd like to be able to change defaults at some point and would like to see the general opinion first. I can't think of a better way of getting feedback, short of opt-in telemetry. That's a different discussion :) ## Checks - [ ] I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle - [ ] I have checked that there are no existing pull requests for the same thing

If you have opinions there, I’d really appreciate you reacting to the PR! The votes there will decide if I merge it or not.

I’m also open to feedback on how to collect this kind of information in the future.

I reference the possibility of opt-in telemetry in the PR, as it would be nice to be able to see how most people configure things. If generally people deviate from the defaults, it would make sense to change the defaults.

But if this kind of polling works out ok, then maybe it’s not needed.

herbcso · July 10, 2024, 11:39am

FWIW I’d prefer this kind of polling to telemetry. However you will also get input mostly from your most hard-core fans this way, so I recognize that telemetry might give you more representative results.

Also, from personal experience, opt-in means that you’ll also get very few people enabling it, mostly hardcore fans again, so that will offset it again. Rock: meet hard place! ;] I don’t think it should be opt-out though. That will leave a sour taste in most people’s mouths, especially these days.

Lastly, I think the survey might be a tad confusing as written - at least for me. I could interpret the as either “I like it full screen” or “I like the change”. I’m not entirely sure what I voted for, but I meant it as “I like it full screen”.

ellie · July 10, 2024, 11:48am

Me too! I’m thinking I’ll leave it open, and link to it from the next release notes. Once that’s gone out, I’ll either merge or close the PR.

But yeah there’s definitely going to be a bias. I think those that are likely to vote on GitHub are those who are both extra engaged AND extra technical.

Those who enable telemetry are probably just engaged.

From a data-accuracy angle, opt-out telemetry would be best. But it’s not something I’m willing to do Some data is better than none, really.

Serves me right for editing it a bunch - adjusted, thank you.

perynfr · July 22, 2024, 8:59am

Hello, Regarding the screen size, you can enter a parameter in the config that defines it as a percentage